Fix toolchain libraries creation when using ghcWithPackages
#2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylecornec
force-pushed
the
cb/fix-2097
branch
from
6c4ba78 to
c1370e4
Compare
|
I can confirm this fixes the bug. toktok-stack builds completely and all tests pass with this PR. |
When using `ghcWithPackages` package db config files are symlinked into the package database directory referencing the real ghc store path. We assume the real ghc file is also accessible from the toplevel ghc-with-packages store path, which is symlinked into the toolchain repository.
Also expand files directly instead of generating glob calls, which is needed for ncurses from nixpkgs since it includes self-referencing symlinks which Bazel does not support (see [33]). [33]: bazelbuild/bazel#133
ylecornec
force-pushed
the
cb/fix-2097
branch
from
c1370e4 to
5a9e66d
Compare
|
Thank you @ylecornec for adding the test and pushing this through! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2097
When using
ghcWithPackagespackage db config files are symlinked into the package databasedirectory referencing the real ghc store path.
We assume the real ghc file is also accessible from the toplevel ghc-with-packages store path,
which is symlinked into the toolchain repository.