Make the flags passed to Stack match Cabal #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio rebase |
Cabal uses '+' to enable a flag, and '-' to disable a flag. Stack builds a dictionary that has either 'flag: true', or 'flag: false'. The behavior before was passing inconsistent flags to the different tools. Have cabal.bzl handle all the flags that we could pass to cabal. This helps to aid people new to rules_haskell. It also allows negating a flag, which didn't work before.
✅ Branch has been successfully rebased |
avdv
force-pushed
the
kb/cabal-flags-plus-minus
branch
from
fb9f356 to
926f079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cabal uses '+' to enable a flag, and '-' to disable a flag. Stack builds a dictionary that has either 'flag: true', or 'flag: false'. The behavior before was passing inconsistent flags to the different tools. Have cabal.bzl handle all the flags that we could pass to cabal. This helps to aid people new to rules_haskell. It also allows negating a flag, which didn't work before.