Provider refactoring, make REPL work with bin targets #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, binary targets with Main module located in files named differently than ‘Main.hs’.
Fuuzetsu
reviewed
Mar 15, 2018
| binfo = dep[HaskellBuildInfo] | ||
| package_names = acc.package_names | ||
| if HaskellBinaryInfo in dep: | ||
| fail("Target {0} cannot depend on binary".format(ctx.attr.name)) |
There was a problem hiding this comment.
I actually think we should allow binaries as input somehow. For example if you need additional build tool available at build time to pre-process some files. Having said that, it has nothing to do with this PR, I was just reminded of it here. We might want to open an issue (or ignore it for now though I on a client project we have precisely such a need so current rules_haskell could not be used there). Alternative is to put the burden on user to make a rule to preprocess sources themselves which is fine I guess.
There was a problem hiding this comment.
Let's open an issue for this.
Fuuzetsu
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #182.
That is, binary targets with
Mainmodule located in files named differently thanMain.hs. The refactoring also prepares ground for work on #179.