Handle CPU value darwin_arm64
#1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdv
force-pushed
the
support-darwin-arm64
branch
from
47c1a32 to
47bebdb
Compare
avdv
force-pushed
the
support-darwin-arm64
branch
from
661e125 to
19694f0
Compare
This brings the versions in the generator script and the current versions in `ghc_bindist.bzl` up to par. Note, the `upstream` value of `ARCHES` is a list of names now, since for different GHC versions, there are different supported Debian binary distributions (e.g. GHC 8.8.4 has deb8 and deb9, but 8.10.1 does not support deb8 anymore). The first available "upstream" that is available in the hashes is selected.
Skydoc is likely no problem anymore, since we are using Stardoc.
Since older versions of GHC do not support this architecture, a missing architecture for a given version is no longer required and just leads to a warning.
- run `bazel run @rules_haskell//haskell:gen-ghc-bindist` - format with buildifier
We use the amd64 binary, which also runs on M1 using Rosetta.
avdv
force-pushed
the
support-darwin-arm64
branch
2 times, most recently
from
07c175a to
a065039
Compare
aherrmann
approved these changes
May 19, 2022
| @@ -15,6 +15,25 @@ | |||
| # `ignore_prefixes` is the prefix of files to ignore | |||
| # `ignore_suffixes` is the suffix of files to ignore | |||
| VERSIONS = [ | |||
| { "version": "9.2.1", | |||
There was a problem hiding this comment.
Nice, thanks a lot for reviving this script!
Includes tweag/rules_sh#21 which adds support for arm64 for OSX and Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Recognize the arm64 architecture correctly so that rules_haskell works on M1 Macs.
Fixes #1737
TODO
build --nobuildwith bindistbuild --nobuildwith nixpkgsarm64CPU value correctly for OSX and Windows rules_sh#21 is mergedFollow ups
update build_bazel_rules_nodejs to version 5.x as this seems to be required for darwin arm64 support, see (Apple M1 ARM64 - Detection issues bazel-contrib/rules_nodejs#3438)\edit: this issue is only relevant for running nodejs applications and does not relate to arm64 support in general