Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell_module: Pass cc toolchain linker flags when using the interpreter #1686

Merged
merged 3 commits into from
Jan 26, 2022
Merged

haskell_module: Pass cc toolchain linker flags when using the interpreter #1686

merged 3 commits into from
Jan 26, 2022

Conversation

facundominguez
Copy link
Member

This gets rid of the "warning: type and size of dynamic symbol ... are not defined"

aherrmann
aherrmann approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!
Only one minor comment.

haskell/experimental/private/module.bzl Outdated Show resolved Hide resolved
@facundominguez facundominguez added the merge-queue merge on green CI label Jan 26, 2022
@facundominguez facundominguez merged commit 9772e52 into master Jan 26, 2022
@facundominguez facundominguez deleted the fd/linkerflags branch January 26, 2022 14:54
@mergify mergify bot removed the merge-queue merge on green CI label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann aherrmann aherrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facundominguez @aherrmann