Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete the Cabal API documentation #1354

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Complete the Cabal API documentation #1354

merged 2 commits into from
Jun 4, 2020

Conversation

aherrmann
Copy link
Member

The Cabal API documentation for haskell_cabal_binary, haskell_cabal_library, and stack_snapshot was not documenting all attributes.

This PR adds docstrings for the missing attributes and also extends the documentation around setup_deps as suggested here: #1347 (review)

@aherrmann aherrmann requested a review from hanshoglund June 4, 2020 10:19
hanshoglund
hanshoglund approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@hanshoglund hanshoglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hanshoglund hanshoglund added the merge-queue merge on green CI label Jun 4, 2020
@mergify mergify bot merged commit 134df43 into master Jun 4, 2020
@mergify mergify bot deleted the cabal-docs branch June 4, 2020 12:56
@mergify mergify bot removed the merge-queue merge on green CI label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshoglund hanshoglund hanshoglund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aherrmann @hanshoglund