Fix bindists on Darwin #1017
Merged
Fix bindists on Darwin #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSD sed apparently does not have the same semantics as GNU sed. The sed script will not be applied to all file arguments, unlike with GNU sed. So to work around this, we pass `-n1` to `xargs`, to limit each call to `sed` to exactly one file argument.
Profpatsch
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BSD sed apparently does not have the same semantics as GNU sed. The
sed script will not be applied to all file arguments, unlike with GNU
sed. So to work around this, we pass
-n1toxargs, to limit eachcall to
sedto exactly one file argument.Fixes #1016
Closes #884