Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package management CLI, part 1 #2146

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Package management CLI, part 1 #2146

wants to merge 24 commits into from

Conversation

jneem
Copy link
Member

@jneem jneem commented Jan 24, 2025

This is the first part of the package manager CLI, hidden behind a "experimental-package" feature flag. It initially supports only git and path dependencies.

  • Allow the git repo realization to check for up-to-date git repos using an existing lock file.
  • Thoroughly test the manifest deserialization
  • Test the is-lock-file-up-to-date logic
  • Integration tests involving the cli
  • Progress messages during git operations

jneem added 3 commits January 24, 2025 16:01
Copy over the cli changes

Fix docs

Update tests for the manifest changes

Switch to libtest-mimic for package tests

Remove an unwrap

Knock out some more easy TODOs

Remove the index
@jneem jneem force-pushed the npm-without-index branch from 0cf4b4c to 336b132 Compare January 28, 2025 03:02
@jneem jneem force-pushed the npm-without-index branch from ca59874 to 19b1cb1 Compare January 28, 2025 06:46
@jneem jneem marked this pull request as ready for review January 30, 2025 12:05
@jneem
Copy link
Member Author

jneem commented Jan 30, 2025

I haven't added a progress bar to the git downloads, but I think this is ready for a first look.

This does auto-updating of the lock-file, like cargo but unlike npm. I haven't yet implemented re-using the standard library across evaluation of multiple manifests, but I think it shouldn't be too hard (certainly easier than the general case of #2140 where you want to re-use work across nickel invocations).

@jneem jneem requested a review from yannham January 30, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant