-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further improvements to pretty-printing in cooked v2 #228
Conversation
06f8782
to
1b70021
Compare
1b70021
to
a788004
Compare
43ea0df
to
2e9145d
Compare
2e9145d
to
289a4e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be ideal to somehow avoid explicit pcOpts
in every function in testing, but I'm not sure it could be reasonably done so. Looks good!
I agree it is not ideal but since we often define wrappers for the testing functions during audits (e.g. to include our custom initial distribution) I do not expect it to be a big hindrance in practice. We also plan to modernize that module which is mostly legacy from V1 at this point (e.g. to print more information about how many traces have been evaluated). There are chances we will reconsider the API in the near future. |
e976fe3
to
e0aa5a5
Compare
4e0116b
to
5f6909e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this!
This PR aims at introducing the following improvements to pretty-printing in cooked v2:
PrettyCooked
class to be able to override pretty printing of Plutus types that are used as datum or redeemers without being encapsulated in a newtype (e.g.TxOutRef
as minting redeemer inAuction
). Also, such a class provides options for pretty printing.Staged
module in which they don't belong