-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix Issue #15683] readonly
input should not have a not-allowed cursor
#15703
Conversation
👍 from me |
One quick thought though—let's check the docs to see if there's anything we need to update language-wise for referring to the cursors of |
I can modify the text on disabled state (which currently is, "Add the Minor changes to the readonly section may be necessary. Currently, it is "Add the Thoughts? |
@kkirsche Yeah, I can dig that, and that sounds like it'd address both changes clearly enough. I'd suggest going with the following copy though:
|
No, I think that works well. If @cvrebert agrees I'll make those changes 👍 Thanks for the feedback |
SGTM. |
Updated. Thank you both for the feedback. I took the liberty of linking the disabled input text on the |
… cursor [Fix Issue twbs#15683] `readonly` input should not have a `not-allowed` cursor. Instead, this pull request displays a standard cursor and only displays the not-allowed cursor on disabled items. Revise docs wording to clarify cursor display
Squashed commits into single due to small size of this change and it seems to have stabilized in regards to feedback. |
Just wanted to follow up on this and see if anything was missing. |
[Fix Issue #15683] `readonly` input should not have a not-allowed cursor
Thanks guys! |
[Fix Issue #15683]
readonly
input should not have anot-allowed
cursor. Instead, this pull request displays a standard cursor and only displays the not-allowed cursor on disabled items.