Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Support #10672

Closed
wants to merge 40 commits into from
Closed

RTL Support #10672

wants to merge 40 commits into from

Conversation

mtawil
Copy link

@mtawil mtawil commented Sep 17, 2013

this is a complete implementation to support RTL via html direction ( if RTL or NOT RTL )

@arechsteiner
Copy link
Contributor

Nice! I had clients ask about RTL support for my Bootstrap themes.

@ggam
Copy link
Contributor

ggam commented Sep 17, 2013

Related to #9397 and all the other rtl proposals (#9913, #6423, #8981, etc).

@lafikl
Copy link

lafikl commented Sep 17, 2013

AMAZING!!
good job mohammed..

@homaily
Copy link

homaily commented Sep 17, 2013

Nice Mohammad !

@jaetea
Copy link

jaetea commented Sep 17, 2013

Good work!

But, wouldn't it make more sense to add a .rtl class to the body and style it based on that tag since IE8 doesn't understand the :not pseudo selector?

@mtawil
Copy link
Author

mtawil commented Sep 17, 2013

Thanks everyone!

@jaetea, no problem! we can use a html class detection instead of attribute :)

@mtawil
Copy link
Author

mtawil commented Oct 4, 2013

Hi @mdo,
do you prefer use the :not pseudo selector to detect a Non RTL documents or use the class detection way like:

html.bootstrap .css-selector { }
html.bootstrap-rtl .css-selector { }
<html class="bootstrap">
<html class="bootstrap-rtl">

@morteza
Copy link

morteza commented Oct 16, 2013

The project at http://github.com/morteza/bootstrap-rtl uses the theming capability added to bootstrap3 to make it RTL. It does not change bootstrap3 core, and does not even need adding stuff to your or tags. Check its provided examples (Same as what bootstrap provided without any change)…

The only thing we have to do, is to add the bootstrap-rtl.css just after the bootstrap.css, themes from 3rd party like those from themestrap and bootswatch are also supported.

Using theme feature of bootstrap 3 could be cleanest possible method.

@cvrebert cvrebert mentioned this pull request Dec 19, 2013
@mdo
Copy link
Member

mdo commented Dec 19, 2013

I overlooked this completely and hadn't realized it was open until now. I don't think we'll be going this route of having all these styles inline—too much bloat for those who don't want or need it. The optional file makes the most sense to me at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants