-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL Support #10672
RTL Support #10672
Conversation
Nice! I had clients ask about RTL support for my Bootstrap themes. |
AMAZING!! |
Nice Mohammad ! |
Good work! But, wouldn't it make more sense to add a .rtl class to the body and style it based on that tag since IE8 doesn't understand the :not pseudo selector? |
Thanks everyone! @jaetea, no problem! we can use a html class detection instead of attribute :) |
Hi @mdo, html.bootstrap .css-selector { }
html.bootstrap-rtl .css-selector { } <html class="bootstrap">
<html class="bootstrap-rtl"> |
The project at http://github.com/morteza/bootstrap-rtl uses the theming capability added to bootstrap3 to make it RTL. It does not change bootstrap3 core, and does not even need adding stuff to your or tags. Check its provided examples (Same as what bootstrap provided without any change)… The only thing we have to do, is to add the bootstrap-rtl.css just after the bootstrap.css, themes from 3rd party like those from themestrap and bootswatch are also supported. Using theme feature of bootstrap 3 could be cleanest possible method. |
I overlooked this completely and hadn't realized it was open until now. I don't think we'll be going this route of having all these styles inline—too much bloat for those who don't want or need it. The optional file makes the most sense to me at this time. |
this is a complete implementation to support RTL via html direction ( if RTL or NOT RTL )