Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar max-width styles should be based on @grid-float-breakpoint #10395

Closed
mrDlef opened this issue Sep 3, 2013 · 1 comment
Closed

Navbar max-width styles should be based on @grid-float-breakpoint #10395

mrDlef opened this issue Sep 3, 2013 · 1 comment

Comments

@mrDlef
Copy link

mrDlef commented Sep 3, 2013

Now we can choose when the navbar stops collapsing with the @grid-float-breakpoint variable but some styles are based on @screen-xs-max instead of @grid-float-breakpoint
We should maybe add a @grid-float-breakpoint-max in the variables.less file and use it.
@mdo
Copy link
Member

mdo commented Sep 3, 2013

Dupe of #10371.

@mdo mdo closed this as completed Sep 3, 2013
@bassjobsen bassjobsen mentioned this issue Sep 5, 2013
Closed
mdo added a commit that referenced this issue Dec 5, 2013
@mdo
Fixes #11610: Add @grid-float-breakpoint-max to better link navbar be…
45930ac 
…havior across viewports and improve customization.

Also addresses #10371, #10395, and #10465.
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
@mdo
(less) Fixes twbs#11610: Add @grid-float-breakpoint-max to better lin…
71d3d5f 
…k navbar behavior across viewports and improve customization.

Also addresses twbs#10371, twbs#10395, and twbs#10465.
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@mdo
(less) Fixes twbs#11610: Add @grid-float-breakpoint-max to better lin…
d5f5ccc 
…k navbar behavior across viewports and improve customization.

Also addresses twbs#10371, twbs#10395, and twbs#10465.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdo @mrDlef