Skip to content

Commit

Permalink
fixes #10153: restore headings-color variable
Browse files Browse the repository at this point in the history
  • Loading branch information
mdo committed Sep 1, 2013
1 parent 9e541fc commit 794d784
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 6 deletions.
2 changes: 1 addition & 1 deletion assets/js/raw-files.js

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions customize.html
Original file line number Diff line number Diff line change
Expand Up @@ -421,15 +421,14 @@ <h4>Headings</h4>
<div class="col-lg-6">
<label>@headings-font-family</label>
<input type="text" class="form-control" placeholder="@font-family-base" data-var="@headings-font-family">
<p class="help-block">Choose a separate font-family for headings.</p>
<label>@headings-font-weight</label>
<input type="text" class="form-control" placeholder="500" data-var="@headings-font-weight">
<p class="help-block">Choose a separate font-weight for headings.</p>
</div>
<div class="col-lg-6">
<label>@headings-line-height</label>
<input type="text" class="form-control" placeholder="1.1" data-var="@headings-line-height">
<p class="help-block">Choose a separate line-height for headings.</p>
<label>@headings-color</label>
<input type="text" class="form-control" placeholder="inherit" data-var="@headings-color">
</div>
</div>

Expand Down
4 changes: 3 additions & 1 deletion dist/css/bootstrap.css
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,8 @@ p {
}
}

small {
small,

This comment has been minimized.

Copy link
@koenpunt

koenpunt Oct 4, 2013

Contributor

small{} is already defined at line 109

This comment has been minimized.

Copy link
@cvrebert

cvrebert Oct 4, 2013

Collaborator

@koenpunt That's part of normalize.css, which we treat as vendored and thus try to avoid modifying.

.small {
font-size: 85%;
}

Expand Down Expand Up @@ -458,6 +459,7 @@ h6,
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
font-weight: 500;
line-height: 1.1;
color: inherit;
}

h1 small,
Expand Down
2 changes: 1 addition & 1 deletion dist/css/bootstrap.min.css

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions less/type.less
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ h1, h2, h3, h4, h5, h6,
font-family: @headings-font-family;
font-weight: @headings-font-weight;
line-height: @headings-line-height;
color: inherit;

This comment has been minimized.

Copy link
@ggam

ggam Sep 1, 2013

Contributor

Should not this use the new @headings-color?


small {
font-weight: normal;
Expand Down
2 changes: 2 additions & 0 deletions less/variables.less
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@
@headings-font-family: @font-family-base;
@headings-font-weight: 500;
@headings-line-height: 1.1;
@headings-color: inherit;


// Iconography
// -------------------------
Expand Down

0 comments on commit 794d784

Please sign in to comment.