Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments from desktop entry are broken up #109

Closed
Vladimir-csp opened this issue Jun 8, 2024 · 4 comments
Closed

Arguments from desktop entry are broken up #109

Vladimir-csp opened this issue Jun 8, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Vladimir-csp
Copy link

Hi!
Testing uwsm integration via a desktop entry, I have this line in /usr/share/wayland-sessions/sway-uwsm.desktop:

Exec=uwsm start -N Sway -C "An i3-compatible Wayland compositor" sway

It fails with "i3-compatible" is not in PATH!, which means that "An i3-compatible Wayland compositor" argument was broken up.

@Vladimir-csp
Copy link
Author

    ├─session-147.scope
    │ ├─1567388 /usr/bin/emptty --daemon --tty tty8 --config /etc/emptty/conf-tty8
    │ ├─1567437 /usr/bin/python3 /usr/bin/uwsm start -N Sway -C "\"An_i3-compatible_Wayland_compositor\"" sway
    │ └─1567451 systemctl --user start --wait [email protected]

Quote handling seems to be missing.

@tvrzna tvrzna self-assigned this Jun 8, 2024
@tvrzna tvrzna added the bug Something isn't working label Jun 8, 2024
@tvrzna
Copy link
Owner

tvrzna commented Jun 8, 2024

Hi,
you are right, there is very basic way for handling of Exec and it was simple split by space, which is insufficient for given example. Please, review changeset.

@Vladimir-csp
Copy link
Author

It won't cover the whole spec, but at least simple quoted arguments would work, which would probably be sufficient for most wayland-sessions cases.

@tvrzna
Copy link
Owner

tvrzna commented Jun 8, 2024

The specifications are meant for desktop applications, for DEs/WMs it's overkill.

@tvrzna tvrzna closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants