Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/msteinert/pam to v2 #107

Closed
supertassu opened this issue Jun 1, 2024 · 6 comments
Closed

Update github.com/msteinert/pam to v2 #107

supertassu opened this issue Jun 1, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@supertassu
Copy link

Hi, there's a new major version v2 of the https://github.com/msteinert/pam library used for PAM authentication. Please consider updating to it.

@tvrzna tvrzna self-assigned this Jun 3, 2024
@tvrzna tvrzna added the enhancement New feature or request label Jun 3, 2024
@tvrzna
Copy link
Owner

tvrzna commented Jun 3, 2024

Hello, I assume, that it's related to the fact of not using thread unsafe finalizer and call transaction.End() on ownself. Or is there any other reason since PAM itself is dynamically linked?
I'll check changelogs and I'll try to update the library.

tvrzna added a commit that referenced this issue Jun 3, 2024
Fixed authPam handleErr not detecting nil value of err.
@tvrzna
Copy link
Owner

tvrzna commented Jun 5, 2024

The update of library led to the dropping of support of older (< 1.20) Golang, which I initially wanted to avoid. However time goes forward and older versions of Golang are no longer supported more than 9 months now. At least it let me to remove usage of deprecated methods and directives.

@tvrzna tvrzna closed this as completed Jun 5, 2024
@supertassu
Copy link
Author

Thanks! Are you planning to do a new release with this or leaving that for later?

@tvrzna
Copy link
Owner

tvrzna commented Jun 6, 2024

Not yet, no one reported any issue with older version of library, so I don't consider it as critical.

@supertassu
Copy link
Author

Ok. A new release would be helpful since I need to update emptty in Debian so that I can update the golang-github-msteinert-pam Debian package to v2. Packaging a full release would be nicer but I can also just pull the last few commits from master to the package for now until there's a new tagged release.

@tvrzna
Copy link
Owner

tvrzna commented Jun 7, 2024

Well, then it is a different story. I'll release emptty as v0.12.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants