samples/bpf: Fix fout leak in hbm's run_bpf_prog

BugLink: https://bugs.launchpad.net/bugs/2028808 [ Upstream commit 23acb14 ] Fix fout being fopen'ed but then not subsequently fclose'd. In the affected branch, fout is otherwise going out of scope. Signed-off-by: Hao Zeng <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Link: https://lore.kernel.org/bpf/[email protected] Signed-off-by: Sasha Levin <[email protected]> Signed-off-by: Kamal Mostafa <[email protected]> Signed-off-by: Stefan Bader <[email protected]>
tuxedocomputers · Aug 9, 2023 · 4bfb4d2 · 4bfb4d2
1 parent b8bc592
commit 4bfb4d2
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/samples/bpf/hbm.c b/samples/bpf/hbm.c
@@ -315,6 +315,7 @@ static int run_bpf_prog(char *prog, int cg_id)
 		fout = fopen(fname, "w");
 		fprintf(fout, "id:%d\n", cg_id);
 		fprintf(fout, "ERROR: Could not lookup queue_stats\n");
+		fclose(fout);
 	} else if (stats_flag && qstats.lastPacketTime >
 		   qstats.firstPacketTime) {
 		long long delta_us = (qstats.lastPacketTime -