setPresenceStatus: status_msg defaults to undefined #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
May 19, 2022
There was a problem hiding this comment.
otherwise lgtm
this should also get a test if it doesn't have one please :)
the longer history on the status_msg is a long-term belief of mine that the spec should accept or declare nullability on fields, and synapse is probably in the wrong for validating this so strictly.
Co-authored-by: Travis Ralston <[email protected]>
turt2live
reviewed
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
Fixes matrix-org/matrix-appservice-discord#591
Correct according to Matrix Spec 1.2: https://spec.matrix.org/v1.2/client-server-api/#put_matrixclientv3presenceuseridstatus
Sidenote: On the Matrix Spec the type of
msg_type's type is[string null]for the HTTP GET method. Maybe that's were the confusion came from.https://spec.matrix.org/v1.2/client-server-api/#get_matrixclientv3presenceuseridstatus