Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remix docs #156

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix remix docs #156

merged 1 commit into from
Mar 11, 2024

Conversation

alcpereira
Copy link
Contributor

The current docs for Remix were containing some issues:

  • The import is forced to http with @libsql/client/http, while I think it's better to let the environment import what it will need
  • The environment variables were defined through AppLoadContext, but it's only recommended for a specific case of local development. I think recommending process.env and letting the user choose how to handle its type is generally better
  • A small typo in the import of the turso client in app/routes/_index.tsx (buildDbClient instead of turso)
  • A redundant type LoaderArgs which is deprecated (see here) and already covered by LoaderFunction (see below)
export type LoaderFunction = (args: LoaderFunctionArgs) => ReturnType<RRLoaderFunction>;

Copy link
Member

@notrab notrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you 🙏

@notrab notrab merged commit 25ac461 into tursodatabase:main Mar 11, 2024
@alcpereira alcpereira deleted the fix-remix-docs branch March 11, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants