Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: mount correct microSD partition, and only if present #38

Merged
merged 1 commit into from
May 17, 2023
Merged

init: mount correct microSD partition, and only if present #38

merged 1 commit into from
May 17, 2023

Conversation

ruslashev
Copy link
Contributor

Previously, if a microSD card was not inserted, this would print an unnecessary message. And if a card is formatted with only one partition, then /dev/mmcblk0p1 would not exist, and mount will fail.

@ruslashev
init: mount correct microSD partition, and only if present
47fc793 
Previously, if a microSD card was not inserted, this would print an
unnecessary message. And if a card is formatted with only one partition,
then `/dev/mmcblk0p1` would not exist, and `mount` will fail.
@svenrademakers svenrademakers merged commit 489c774 into master May 17, 2023
ruslashev added a commit that referenced this pull request May 17, 2023
@ruslashev
init: create /mnt/sdcard if not present
4a6e2ec 
PR #38 was merged a bit too early, as there's a case when this directory
does not exist at mount time. In addition, move mounting before printing
the banner just because it outputs some messages to syslog.

Closes #38
@ruslashev ruslashev mentioned this pull request May 17, 2023
Merged
ruslashev added a commit that referenced this pull request May 17, 2023
@ruslashev
init: create /mnt/sdcard if not present
5db7fe9 
PR #38 was merged a bit too early, as there's a case when this directory
does not exist at mount time. In addition, move mounting before printing
the banner just because it outputs some messages to syslog.

Closes #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenrademakers svenrademakers svenrademakers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruslashev @svenrademakers