Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: github.com/oras-project/oras-credentials-go was merged into oras.land/oras-go/v2 #3900

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Sep 26, 2023

@pdecat pdecat marked this pull request as ready for review October 24, 2023 12:16
@pdecat
Copy link
Contributor Author

pdecat commented Oct 24, 2023

Hi @binaek, this is now ready for review :)

@pdecat
Copy link
Contributor Author

pdecat commented Oct 24, 2023

Oops, spoke too soon, v2.3.1 was made from https://github.com/oras-project/oras-go/tree/release-2.3 which does not include the merged package.

@pdecat pdecat marked this pull request as draft October 24, 2023 12:24
@pdecat
Copy link
Contributor Author

pdecat commented Oct 25, 2023

This will have to wait for v2.4.0 of oras-go: https://github.com/oras-project/oras-go/milestone/17

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Dec 24, 2023
@pdecat
Copy link
Contributor Author

pdecat commented Dec 24, 2023

keep

@github-actions github-actions bot removed the stale No recent activity has been detected on this issue/PR and it will be closed label Dec 25, 2023
@kaidaguerre
Copy link
Contributor

Hey @pdecat sorry for the delay on this one - let's try to get it merged in. Could you rebase

@pdecat
Copy link
Contributor Author

pdecat commented Jan 2, 2024

Hi @kaidaguerre, actually this PR is not ready as the release of oras-go including the required bits is not yet released #3900 (comment)

See https://github.com/oras-project/oras-go/milestone/17

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2024

CLA assistant check
All committers have signed the CLA.

@pdecat
Copy link
Contributor Author

pdecat commented Jan 11, 2024

Rebased on main and updated to use oras.land/oras-go/v2 v2.3.1-0.20231015113306-e8e4f843df97

Still waiting on a proper release to mark the PR as ready.

Only two issues left open for the milestone 🤞 https://github.com/oras-project/oras-go/milestone/17

@pdecat
Copy link
Contributor Author

pdecat commented Jan 30, 2024

@pdecat pdecat marked this pull request as ready for review January 30, 2024 11:38
@pdecat
Copy link
Contributor Author

pdecat commented Jan 30, 2024

Looks like the failing check is caused by a network timeout:

Warning: Failed to download action 'https://api.github.com/repos/actions/download-artifact/tarball/9bc31d5ccc31df68ecc42ccf4149144866c47d8a'. Error: Operation timed out (codeload.github.com:443)
Warning: Back off 17.101 seconds before retry.
Error: Operation timed out (api.github.com:443)

https://github.com/turbot/steampipe/actions/runs/7710558276/job/21014172562?pr=3900

@kaidaguerre
Copy link
Contributor

Hey @pdecat could you rebase this one more time and I'll finally merge it.

@pdecat
Copy link
Contributor Author

pdecat commented Mar 1, 2024

Done!

FYI, Github PRs are facing issues ATM: https://www.githubstatus.com/incidents/wcl1sw4mzg60

@kaidaguerre kaidaguerre merged commit c7e6d46 into turbot:main Mar 1, 2024
59 of 60 checks passed
@kaidaguerre
Copy link
Contributor

Finally! Thanks for your patience

@pdecat pdecat deleted the deps/oras-go branch March 1, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants