-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: github.com/oras-project/oras-credentials-go was merged into oras.land/oras-go/v2 #3900
Conversation
Hi @binaek, this is now ready for review :) |
Oops, spoke too soon, v2.3.1 was made from https://github.com/oras-project/oras-go/tree/release-2.3 which does not include the merged package. |
This will have to wait for v2.4.0 of oras-go: https://github.com/oras-project/oras-go/milestone/17 |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
keep |
Hey @pdecat sorry for the delay on this one - let's try to get it merged in. Could you rebase |
Hi @kaidaguerre, actually this PR is not ready as the release of oras-go including the required bits is not yet released #3900 (comment) See https://github.com/oras-project/oras-go/milestone/17 |
Rebased on main and updated to use oras.land/oras-go/v2 v2.3.1-0.20231015113306-e8e4f843df97 Still waiting on a proper release to mark the PR as ready. Only two issues left open for the milestone 🤞 https://github.com/oras-project/oras-go/milestone/17 |
Looks like the failing check is caused by a network timeout:
https://github.com/turbot/steampipe/actions/runs/7710558276/job/21014172562?pr=3900 |
Hey @pdecat could you rebase this one more time and I'll finally merge it. |
…s.land/oras-go/v2 Signed-off-by: Patrick Decat <[email protected]>
Done! FYI, Github PRs are facing issues ATM: https://www.githubstatus.com/incidents/wcl1sw4mzg60 |
Finally! Thanks for your patience |
https://github.com/oras-project/oras-go/tree/main/registry/remote/credentials is now part of a the v2.4.0 release.