Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete results should not be added to cache if the context is cancelled #339

Closed
kaidaguerre opened this issue Jun 16, 2022 · 0 comments · Fixed by #340
Closed

Incomplete results should not be added to cache if the context is cancelled #339

kaidaguerre opened this issue Jun 16, 2022 · 0 comments · Fixed by #340

Comments

@kaidaguerre
Copy link
Contributor

If the FDW crashes, the context passed to the plugin gets cancelled and the execution interrupted. However the sdk is not checking the cancellation status before writing to the cache, leading to incomplete/empty results being cached

Solution is to stream the context error if non nil before closing the row data channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant