Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add labels and tags columns to gcp_compute_global_forwarding_rule table #678

Merged

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Oct 29, 2024

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
> select md5(name) as name, labels -> 'deployed_by', tags -> 'deployed_by' from gcp_compute_global_forwarding_rule where labels is not null limit 1
+----------------------------------+-------------+-------------+
| name                             | ?column?    | ?column?    |
+----------------------------------+-------------+-------------+
| f2811506722a00854dc34817929e5c1e | "terraform" | "terraform" |
+----------------------------------+-------------+-------------+

@pdecat pdecat changed the title feat: add labels column to gcp_compute_global_forwarding_rule table feat: add labels column to gcp_compute_global_forwarding_rule table Oct 29, 2024
@ParthaI
Copy link
Contributor

ParthaI commented Oct 29, 2024

Hello @pdecat, the changes look good to me!

Would you mind adding the Steampipe standard column tags as well, as we’ve done for other tables?
For reference, please see:

Also, could you include the query result in the PR body?

Thanks!

@pdecat
Copy link
Contributor Author

pdecat commented Oct 29, 2024

Sure, done!

@pdecat pdecat changed the title feat: add labels column to gcp_compute_global_forwarding_rule table feat: add labels and tags columns to gcp_compute_global_forwarding_rule table Oct 29, 2024
@misraved misraved merged commit db459c9 into turbot:main Oct 29, 2024
1 check passed
@pdecat pdecat deleted the feat/gcp_vpc_global_forwarding_rule_labels branch October 29, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants