Add table gcp_cloud_run_service Closes #479 #497

ParthaI · 2023-10-03T11:10:05Z

Integration test logs

Logs

Add passing integration test logs here

Example query results

Results

> select * from gcp_cloud_run_service
+-------+---------------+----------------+-------------+---------------------------+-------------+-----------------------+----------------------------------------------------------------------------------------------+-------------+------------+---------------------+--->
| name  | client        | client_version | description | create_time               | delete_time | creator               | etag                                                                                         | expire_time | generation | ingress             | se>
+-------+---------------+----------------+-------------+---------------------------+-------------+-----------------------+----------------------------------------------------------------------------------------------+-------------+------------+---------------------+--->
| hello | cloud-console |                |             | 2023-09-04T16:43:16+05:30 | <null>      | [email protected] | "CIDb76gGEOiEfg/cHJvamVjdHMvcGFya2VyLWFhYS9sb2NhdGlvbnMvdXMtY2VudHJhbDEvc2VydmljZXMvaGVsbG8" | <null>      | 2          | INGRESS_TRAFFIC_ALL | ht>
+-------+---------------+----------------+-------------+---------------------------+-------------+-----------------------+----------------------------------------------------------------------------------------------+-------------+------------+---------------------+--->

Time: 3.3s. Rows fetched: 1. Hydrate calls: 1.
> select * from gcp_cloud_run_service where name = 'hello' and location = 'us-central1'
+-------+---------------+----------------+-------------+---------------------------+-------------+-----------------------+----------------------------------------------------------------------------------------------+-------------+------------+---------------------+--->
| name  | client        | client_version | description | create_time               | delete_time | creator               | etag                                                                                         | expire_time | generation | ingress             | se>
+-------+---------------+----------------+-------------+---------------------------+-------------+-----------------------+----------------------------------------------------------------------------------------------+-------------+------------+---------------------+--->
| hello | cloud-console |                |             | 2023-09-04T16:43:16+05:30 | <null>      | [email protected] | "CIDb76gGEOiEfg/cHJvamVjdHMvcGFya2VyLWFhYS9sb2NhdGlvbnMvdXMtY2VudHJhbDEvc2VydmljZXMvaGVsbG8" | <null>      | 2          | INGRESS_TRAFFIC_ALL | ht>
+-------+---------------+----------------+-------------+---------------------------+-------------+-----------------------+----------------------------------------------------------------------------------------------+-------------+------------+---------------------+--->

madhushreeray30

@ParthaI Please have a look at the comments, thanks!

madhushreeray30 · 2023-10-04T05:02:13Z

gcp/table_gcp_cloudrun_service.go

We have missed out on adding some columns -

TerminalCondition

Traffic

TrafficStatuses

@madhushreeray30 , I had added traffic_statuses column earlier, rest of missing column I added in.

madhushreeray30 · 2023-10-04T05:02:53Z

gcp/table_gcp_cloudrun_service.go

+				{
+					Name: "location",
+					Require: plugin.Optional,
+				},


Suggested change

{

Name: "location",

Require: plugin.Optional,

},

{

Name: "location",

Require: plugin.Optional,

},

madhushreeray30 · 2023-10-04T05:03:30Z

gcp/table_gcp_cloudrun_service.go

+				Name:        "name",
+				Description: "The fully qualified name of this Service.",
+				Type:        proto.ColumnType_STRING,
+				Transform: transform.FromField("Name").Transform(lastPathElement),


Suggested change

Transform: transform.FromField("Name").Transform(lastPathElement),

Transform: transform.FromField("Name").Transform(lastPathElement),

madhushreeray30 · 2023-10-04T05:04:02Z

gcp/table_gcp_cloudrun_service.go

+	if region != "" && region != location{
+		return nil, nil
+	}


Suggested change

if region != "" && region != location{

return nil, nil

}

if region != "" && region != location {

return nil, nil

}

madhushreeray30 · 2023-10-04T05:12:09Z

docs/tables/gcp_cloud_run_service.md

+  t ->> 'Type' as type
+from
+  gcp_cloud_run_service,
+  jsonb_array_elements(traffic) as t;


Column traffic needs to be added

misraved

@ParthaI please take a look at the review comments. Thanks!!

misraved · 2023-10-03T11:57:47Z

docs/tables/gcp_cloud_run_service.md

@@ -0,0 +1,135 @@
+# Table:  gcp_cloud_run_service


Suggested change

# Table: gcp_cloud_run_service

# Table: gcp_cloud_run_service

misraved · 2023-10-03T11:57:55Z

docs/tables/gcp_cloud_run_service.md

+from
+  gcp_cloud_run_service;
+```
+


Suggested change

misraved · 2023-10-03T11:58:16Z

docs/tables/gcp_cloud_run_service.md

+  reconciling;
+```
+
+### List services that are created in the last 30 days


Suggested change

### List services that are created in the last 30 days

### List services created in the last 30 days

misraved · 2023-10-03T12:24:41Z

gcp/service.go

@@ -23,7 +24,7 @@ import (
 	"google.golang.org/api/logging/v2"
 	"google.golang.org/api/monitoring/v3"
 	"google.golang.org/api/pubsub/v1"
-	"cloud.google.com/go/redis/apiv1"
+	"google.golang.org/api/run/v2"


Does the removal of this package break any other service?

It has been shifted to top automatically after prettifying the code. Nothing is breaking the package name is correct.

misraved · 2023-10-03T12:25:21Z

gcp/table_gcp_cloudrun_service.go

+				Name:        "name",
+				Description: "The fully qualified name of this Service.",
+				Type:        proto.ColumnType_STRING,
+				Transform: transform.FromField("Name").Transform(lastPathElement),


Could you please fix the formatting?

…sue-479

… comments

Add table gcp_cloudrun_service Closes #479

65cc581

ParthaI self-assigned this Oct 3, 2023

ParthaI requested a review from misraved October 3, 2023 11:10

ParthaI linked an issue Oct 3, 2023 that may be closed by this pull request

Add table gcp_cloudrun_service #479

Closed

madhushreeray30 reviewed Oct 4, 2023

View reviewed changes

misraved reviewed Oct 4, 2023

View reviewed changes

ParthaI added 2 commits October 4, 2023 12:05

Merge branch 'main' of github.com:turbot/steampipe-plugin-gcp into is…

b764575

…sue-479

Prettyfy the code rename the file name and made changes as per review…

7a90525

… comments

ParthaI changed the title ~~Add table gcp_cloudrun_service Closes #479~~ Add table gcp_cloud_run_service Closes #479 Oct 4, 2023

madhushreeray30 approved these changes Oct 4, 2023

View reviewed changes

madhushreeray30 merged commit a759191 into main Oct 4, 2023

madhushreeray30 deleted the issue-479 branch October 4, 2023 11:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add table gcp_cloud_run_service Closes #479 #497

Add table gcp_cloud_run_service Closes #479 #497

ParthaI commented Oct 3, 2023

madhushreeray30 left a comment

madhushreeray30 Oct 4, 2023 •

edited

Loading

ParthaI Oct 4, 2023

madhushreeray30 Oct 4, 2023

madhushreeray30 Oct 4, 2023

madhushreeray30 Oct 4, 2023

madhushreeray30 Oct 4, 2023

misraved left a comment

misraved Oct 3, 2023

misraved Oct 3, 2023

misraved Oct 3, 2023

misraved Oct 3, 2023

ParthaI Oct 4, 2023

misraved Oct 3, 2023

	Transform: transform.FromField("Name").Transform(lastPathElement),
	Transform: transform.FromField("Name").Transform(lastPathElement),

	# Table: gcp_cloud_run_service
	# Table: gcp_cloud_run_service

	### List services that are created in the last 30 days
	### List services created in the last 30 days

Add table gcp_cloud_run_service Closes #479 #497

Add table gcp_cloud_run_service Closes #479 #497

Conversation

ParthaI commented Oct 3, 2023

Integration test logs

Example query results

madhushreeray30 left a comment

Choose a reason for hiding this comment

madhushreeray30 Oct 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

misraved left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

madhushreeray30 Oct 4, 2023 •

edited

Loading