-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table gcp_storage_object
. Closes #459
#460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karanpopat Please see review comments, thanks!
}, | ||
List: &plugin.ListConfig{ | ||
KeyColumns: plugin.OptionalColumns([]string{"bucket"}), | ||
ParentHydrate: listGcpStorageBuckets, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't use a parent hydrate for this table, as there could be a lot of buckets with a lot of objects, so if someone runs select * from gcp_storage_object
, they could be waiting a long time (we made the same decision with aws_s3_object
.
|
||
func tableGcpBucketStorageObject(_ context.Context) *plugin.Table { | ||
return &plugin.Table{ | ||
Name: "gcp_storage_bucket_object", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name: "gcp_storage_bucket_object", | |
Name: "gcp_storage_object", |
Even though TF calls it gcp_storage_bucket_object
, I think we should deviate here, unless this new name is ambiguous and there are other GCP Storage objects
gcp_storage_bucket_object
. Closes #459gcp_storage_object
. Closes #459
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karanpopat Thanks for making the previous changes, left 1 more, please have a look, thanks!
Integration test logs
Logs
Example query results
Results