Expand tilde in credential_file configuration #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RyanJarv This is great stuff - thanks! I've used your code already in the (under development) CSV plugin, and it's working great - turbot/steampipe-plugin-csv@a7f5f99 I believe this should be merged in, but will leave it with @rajlearner17 and @bigdatasourav to review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the example configuration at https://hub.steampipe.io/plugins/turbot/gcp uses tildes to represent the users home directory. This doesn't seem to be supported by the GCP SDK however, this PR expands the tilde to the current users home directory to support using the
credential_fileconfiguration this way.Haven't run any tests on this branch yet, I'll need to look into how to do that.
Integration test logs
TODO: Integration tests
Logs