-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table gcp_project_organization_policy. closes #186 #204
Conversation
|
||
```sql | ||
select | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we query specific columns, instead of *
?
|
||
//// TABLE DEFINITION | ||
|
||
func tableGcpProjectsOrganizationPolicy(ctx context.Context) *plugin.Table { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func tableGcpProjectsOrganizationPolicy(ctx context.Context) *plugin.Table { | |
func tableGcpProjectOrganizationPolicy(ctx context.Context) *plugin.Table { |
return nil, err | ||
} | ||
project := projectData.Project | ||
plugin.Logger(ctx).Trace("listGcpProjectOrganizationPolicies", "GCP_PROJECT: ", project) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugin.Logger(ctx).Trace("listGcpProjectOrganizationPolicies", "GCP_PROJECT: ", project) |
project := projectData.Project | ||
|
||
// Get the resource title | ||
title := strings.ToUpper(project) + " Org Policy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Priyanka585464 Is this title required?
You are not using this title
value anywhere.
Currently the title
is using constraint
value
https://github.com/turbot/steampipe-plugin-gcp/pull/204/files#diff-90f64bc506bbef72770fec8f8ca390942b03e818c0b89357a21e3517f02b28b8R70
|
||
variable "gcp_project" { | ||
type = string | ||
default = "pikachu-aaa" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default = "pikachu-aaa" | |
default = "niteowl-aaa" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Priyanka585464 There are few more changes required. Please see comments, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Integration test logs
Logs
Example query results
Results
Check policy's previously updated time by server
Check the policy values given to constraint.