Graviton2 to Graviton #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbruno10
requested changes
Oct 16, 2023
There was a problem hiding this comment.
@bluedoors Can you please see the minor review comment? Thanks!
CHANGELOG.md
Outdated
| @@ -81,7 +81,7 @@ _What's new?_ | |||
| - Secrets Manager Checks (`steampipe check benchmark.secretsmanager`) ([#85](https://github.com/turbot/steampipe-mod-aws-thrifty/pull/85)) | |||
| - New controls added: | |||
| - ec2_instance_older_generation ([#79](https://github.com/turbot/steampipe-mod-aws-thrifty/pull/79)) | |||
| - lambda_function_with_graviton2 ([#82](https://github.com/turbot/steampipe-mod-aws-thrifty/pull/82)) | |||
| - lambda_function_with_graviton ([#82](https://github.com/turbot/steampipe-mod-aws-thrifty/pull/82)) | |||
There was a problem hiding this comment.
@bluedoors Can you please remove this change? The CHANGELOG entry reflects what we added at the time, but we'll call out the rename in the CHANGELOG entry for the next version.
There was a problem hiding this comment.
@cbruno10 Reverted to the previous CHANGELOG
|
@cbruno10 Reverted to the previous CHANGELOG |
cbruno10
approved these changes
Oct 17, 2023
|
Thanks @bluedoors for the contribution! We'll release a new version with these changes either later this week or early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS Graviton is a family of processors designed to deliver the best price performance for your cloud workloads running in Amazon Elastic Compute Cloud (Amazon EC2).
Whilst Graviton2 is mentioned in the code Graviton3 processes have now been released. To future proof the code this PR changes references from [G/g]raviton2 to simply [G/g]raviton