Add connection dimension. Add variable list of tag dimensions (default Owner). #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsmyth
reviewed
Nov 21, 2022
controls/lambda.sp
Outdated
| end as reason, | ||
| region, | ||
| account_id, | ||
| _ctx ->> 'connection_name' as connection |
There was a problem hiding this comment.
I think if we re going to add an ability to specify additional dimensions anyway, we should not hardcode _ctx ->> 'connection_name' as a dimension. The control title already get truncated and this will make it worse. Also, _ctx ->> 'connection_name' is about the only "custom" dimension that you could add anyway right now, since the other common columns are already included.
| @@ -7,6 +7,20 @@ locals { | |||
| } | |||
| } | |||
|
|
|||
| variable "tag_dimensions" { | |||
| type = list(string) | |||
| description = "A list of tags to add as dimensions to each control." | |||
There was a problem hiding this comment.
Maybe the description should state the caveats:
- The added dimension column must appear in every control query ( i assume we are generalizing this?)
- The added dimension column must be unique in every control query (when joining tables)
…sions SQL to include qualifier support when required.
Co-authored-by: misraved <[email protected]>
…lect the common dimensions
misraved
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.