DATETIME & TIMESTAMP support in stringToQualValue function #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds extensive test cases for the stringToQualValue function in filter_to_quals_test.go, covering various column types and input formats. The tests include validation for: - Boolean values - Integer and double values - String and JSON values - Timestamp and datetime parsing with multiple formats - Error handling for invalid inputs The corresponding implementation in main.go.tmpl has been updated to support parsing multiple time formats and Unix timestamps.
pskrbasu
reviewed
Mar 7, 2025
There was a problem hiding this comment.
@itaywaisman Can you add an example with time format to the README as a part of this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds extensive test cases for the stringToQualValue function in filter_to_quals_test.go, covering various column types and input formats. The tests include validation for:
The corresponding implementation in main.go.tmpl has been updated to support parsing multiple time formats and Unix timestamps.
Please let me know if the support I added for multiple datetime and timestamp formats is needed.
Also GO is not my main language and I got help from Claude - any code style comments are much appreciated!