git-coauthors: fix syntax error #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the trigger on an environment configured with the latest version of Ruby you would get a syntax error with an exit code 1.
|
Thanks for your contribution, @deadpyxel! 🎉 We've done some automated sense checks on your trigger, |
|
Thanks @deadpyxel, great catch! |
mcasper
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running the trigger on an environment configured with the latest version of Ruby you would get a syntax error with an exit code 1.
Motivation and Context
We are not sure which version will be installed on the user's machine, so maybe we should err on the side of using the syntax from the latest version.
How Has This Been Tested?
I validated this locally and tested with some pairing sessions, seems to work fine for my case
Additional Context
I am running all this inside MacOS, with my personal environment configured to have latest version(
ruby 3.2.2 (2023-03-30 revision e51014f9c0)of ruby as global default (usingasdfto manage).