Fix #433: Reimplementation of IfcFixedReferenceSweptAreaSolid #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophKaiser
added
example-files
christophKaiser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #433
The function was implemented by pull request #406. The code of this reimplementation was copied (with slight adaptions of variable names and one function parameter) from commit 6035ec2 "implemented support for IfcFixedReferenceSweptAreaSolid" (Stefan Jaud, 15th March 2021), respectively commit c0f621c "Merge pull request #406 from pjanck/Solving405" (Stefan Jaud, 16th March 2021).
Now, the opening of the file in the viewport (UI) and execution of the unit test work again.
I was interested in how the function
convertIfcFixedReferenceSweptAreaSolidgenerates the surface withPolyhedronData, because my current issues aboutIfcAdvancedBrepwith involvedIfcBSplineSurfaceWithKnotsprobably will have to deal withPolyhedronDataas well. Surprisingly, the function was empty. It seems like the code was somehow lost by a merge commit.