Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen shot maker #446

Merged
merged 23 commits into from
Apr 27, 2021
Merged

Screen shot maker #446

merged 23 commits into from
Apr 27, 2021

Conversation

pjanck
Copy link
Contributor

@pjanck pjanck commented Apr 25, 2021

Made a small console application that saves all screen shots needed for unit testing.

Usage:

OpenInfraPlatform.ScreenShotMaker.exe <pathToIfcFile> -o <pathToOutputDirectory>

with:

  • <pathToIfcFile>: the relative or absolute path to the IFC file to be rendered
  • <pathToOutputDirectory>: the relative or absolute path to the directory where screen shots should be saved

NOTE: make sure that the correct IFC version is being compiled - select accordingly in CMake.

@pjanck pjanck added IFC Content related to Industry Foundation Classes (IFC) functionalities example-files Issue related to failing reading an example file quality_of_life Nice to have improvement labels Apr 25, 2021
Copy link
Collaborator

@jschlenger jschlenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Seems like a useful tool to simplify writing unit test.
I think it would make sense to create a new issues to change the existing unit tests to make use of this tool.

@pjanck
Copy link
Contributor Author

pjanck commented Apr 25, 2021

This is not a library, but an .exe - it runs independently. So there is no need for existing unit tests to be adapted.

@pjanck pjanck merged commit 76cd098 into tumcms:development Apr 27, 2021
@pjanck pjanck deleted the ScreenShotMaker branch April 30, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example-files Issue related to failing reading an example file IFC Content related to Industry Foundation Classes (IFC) functionalities quality_of_life Nice to have improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants