WIP: Representation items table #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elvira2227
added
documentation
pjanck
suggested changes
Mar 11, 2021
There was a problem hiding this comment.
Some comments from the top of my head.
Also: we have plenty of unit tests for some of these already rolling. Make sure to check functions called "CheckForEssentialEntity" or sth like that in the unit tests.
NOTE for comments where there is no message "Comment on lines x-y" - these only apply to the last line shown in the code window (github always shows the line + three predecessors).
pjanck
suggested changes
Mar 14, 2021
pjanck
suggested changes
Apr 9, 2021
pjanck
reviewed
Apr 9, 2021
pjanck
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entitys was made until IfcGeometricRepresentationItem ->IfcSurface
Fixes #389 .