Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old python versions #127

Closed
wants to merge 3 commits into from
Closed

Conversation

jasonpenny
Copy link
Contributor

@jasonpenny jasonpenny commented Jan 8, 2019

@hugovk
Copy link
Contributor

hugovk commented Jan 9, 2019

Travis CI does support 3.7, but it needs dist: xenial. So try something like this:

python:
  - 2.7
  - 3.4
  - 3.5
  - 3.6
# Enable 3.7 without globally enabling dist: xenial for other build jobs
matrix:
  include:
    - python: 3.7
      dist: xenial

Or this:

matrix:
  include:
    - python: 2.7
    - python: 3.4
    - python: 3.5
    - python: 3.6
    - python: 3.7
      dist: xenial

@jasonpenny
Copy link
Contributor Author

Thanks @hugovk, that seemed to work

@hugovk
Copy link
Contributor

hugovk commented Jan 13, 2019

Python 3.4 is also EOL in a couple of months (2019-03-16), you could consider dropping that too.

Here's the pip installs for PyTumblr from PyPI for December 2018:

category percent downloads
2.7 88.97% 10,231
3.6 5.51% 634
3.7 2.88% 331
3.5 1.95% 224
null 0.53% 61
3.4 0.15% 17
2.6 0.02% 2
Total 11,500

Source: pypistats python_minor --last-month PyTumblr

@komapa komapa self-requested a review February 6, 2019 06:31
@jasonpenny jasonpenny closed this Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants