Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds customization points for Confirm + Next buttons #91

Merged
merged 6 commits into from
Feb 22, 2021

Conversation

bjtitus
Copy link
Collaborator

@bjtitus bjtitus commented Feb 22, 2021

Adds customization hooks for Confirm + Next buttons following the same approach as KanvasFonts and KanvasColors.

  • Adds confirmAtTop Camera Settings feature
  • Adds KanvasImages shared instance + an initializer for overriding.
  • Adds nextImage and confirmImage KanvasImages objects.
  • Replaces image usage with the shared instance.

See wordpress-mobile/WordPress-iOS#15950 for these customization points in use with white variants.

Copy link
Collaborator

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bjtitus bjtitus force-pushed the stories/confirmAtTop branch from ff4ad9f to 74314d6 Compare February 22, 2021 16:38
@bjtitus bjtitus merged commit 0bdd05a into main Feb 22, 2021
@bjtitus bjtitus deleted the stories/confirmAtTop branch February 22, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants