Fix iOS 18 cell dequeue crash #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerych
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Heya @benjamin-su 👋
Changes LGTM. I did a quick smoke test of the example app as well and saw no issues.
Thanks for wrangling this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A crash occurs on iOS when trying to call on
dequeueReusableCellmethod when it isn't used for display.This PR changes the method used to
cellForItem(at:)instead to prevent crash. (Apple logs specifically mentions the improper use ofdequeue)While we are at it, the returned
cellwas passed to a non optional parameter, but all future uses of it was optional.Turn the parameter to optional, and remove the
assertFailureto make the application more resistant to crashes.