-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified permission flow #133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop settings button from being disabled after camera permission has been given but microphone permission hasn't.
This button used to be the camera access button.
The Views have been quite radically changed these should rewritten or rerecorded once the fix is released.
The existing constraints can't handle changes to their size when changing the text.
The button will never be disabled.
Our coding standards are to use the value but we need to use the existing Orangina translations here.
…an/ICORE-4182-permission-flow
bjtitus
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
…an/ICORE-4182-permission-flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: ICORE-4812
P2: https://wp.me/pbzQyC-248
What it does
This changes how we ask the user for camera and microphone permissions. Apple recently rejected our review as they didn't want an intermediary screen where users can choose whether to display apples official permission requests.
Everything here has been reviewed for orangina as part of this PR and is currently being used within Orangina by pointing at a copy of this branch.
How to test
This might not need testing as it's already been tested when added to Orangina, although in case the example app behaves significantly differently and you'd like to check I've included the testing instructions from the original PR. There's also another PR that will be merged in after this one adding automated tests and removing code, it might be better to test this PR instead
Use a real device, resetting the app permission settings on simulator is a bit tricky.
Unknown permissions
Settings > General > Reset > Reset Location & Privacy
Accepted permissions
Settings > General > Reset > Reset Location & Privacy
Result: Camera and mic should be fully accessible
Denied permissions -
Settings > General > Reset > Reset Location & Privacy