Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor View Delegate fix #122

Merged
merged 5 commits into from
Sep 8, 2021
Merged

Editor View Delegate fix #122

merged 5 commits into from
Sep 8, 2021

Conversation

bjtitus
Copy link
Collaborator

@bjtitus bjtitus commented Sep 7, 2021

Fixes an issue where the delegate of EditorView was not properly set at initialization, causing several delegate methods (like getQuickPostButton) to not be called.

@bjtitus bjtitus self-assigned this Sep 7, 2021
@bjtitus bjtitus requested a review from biscuitehh September 8, 2021 17:49
@bjtitus
Move EditorView.setupViews to viewDidLoad
4d9fe1d 
* Reverts commit caba3e6.
* Moves `EditorView.setupViews()` to `EditorViewController.viewDidLoad`
@bjtitus
Revert "Fix unit test compilation"
2d5ee4d 
This reverts commit 405cc00.
biscuitehh
biscuitehh suggested changes Sep 8, 2021
View reviewed changes
Copy link

@biscuitehh biscuitehh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! Once the unit tests are updated this will be good to merge in. 🚀

@biscuitehh biscuitehh self-requested a review September 8, 2021 20:31
@bjtitus bjtitus merged commit 90f783b into main Sep 8, 2021
@bjtitus bjtitus deleted the bjtitus/editor-view-delegate branch September 8, 2021 20:38
@bjtitus bjtitus mentioned this pull request Dec 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biscuitehh biscuitehh biscuitehh approved these changes

Assignees

@bjtitus bjtitus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjtitus @biscuitehh