Stories: 16.8 Bug Fixes #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This solves an issue with audio playing while media may still be uploading.
aerych
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
Hola @bjtitus 👋
I tested with the associated WPiOS patch on an iPhone 11 Pro running 14.4.
Everything looked good. There were a couple of edge cases we talked about in chat but no worries there. They can be sorted in a later PR.
Code looks good to my yes. The code style is different from our other libs and apps but very readable, and seems pretty consistent with the rest of Kanvas so all good.
from me. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related WP PR: wordpress-mobile/WordPress-iOS#16011
features.resizesFont) to disable or enable dynamic font resizing (Fixes Reduce default font size #70)