New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding methods to python client. #456

Merged

byxorna merged 1 commit into tumblr:master from ytjohn:python-1

Jun 1, 2017

Contributor

ytjohn commented Sep 12, 2016

Added several functions to the python client.

ensure asset - if an asset doesn't exist, create it
get/create/delete/update/ensure assettype
ping - ping the collins api
soft update - update an existing asset key, changing only if required
optimized imports, corrected some comment spacing

Contributor Author

ytjohn commented Sep 12, 2016

Don't have CLA filled out, will work on that today.

Contributor

william-richard commented Sep 12, 2016

This is awesome @ytjohn! Do you want to add yourself to the author list? https://github.com/tumblr/collins/blob/master/support/python/collins_client/setup.py#L8

Contributor Author

ytjohn commented Sep 12, 2016

Will do (re: author's list)


          Adding methods to python client.

43e82e4

ytjohn force-pushed the python-1 branch from 22719ed to 43e82e4 Compare

September 13, 2016 13:49

william-richard approved these changes

View reviewed changes

Contributor

byxorna commented Sep 16, 2016

This LGTM (i cant approve? @Primer42 harsh...)

Contributor

discordianfish commented Oct 28, 2016

@Primer42 Ping? Can this get merged? Looks straight forward to me.

byxorna merged commit 1ab8a94 into tumblr:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet