-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet
#894
feat: support PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet
#894
Conversation
…ershipExceptionSet`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for helping complete this @adincebic
It's worth adding a new fixture or updating existing one to aid testing this
- https://github.com/tuist/XcodeProj/tree/main/Fixtures/Xcode16
- https://github.com/tuist/XcodeProj/blob/main/Tests/XcodeProjTests/Project/XcodeProjIntegrationTests.swift#L7
Running locally I see the comments generated don't quite match what Xcode expects and produces a diff 🙈
e.g.
/* End PBXFileReference section */
/* Begin PBXFileSystemSynchronizedBuildFileExceptionSet section */
- FB5D38CD2D2E61BA00005FF8 /* Exceptions for "XC16SyncGroups" folder in "XC16SyncGroups" target */ = {
+ FB5D38CD2D2E61BA00005FF8 /* PBXFileSystemSynchronizedBuildFileExceptionSet */ = {
isa = PBXFileSystemSynchronizedBuildFileExceptionSet;
membershipExceptions = (
Foo.swift,
);
target = FB5D38AA2D2E618600005FF8 /* XC16SyncGroups */;
};
- FB5D38CE2D2E61BA00005FF8 /* Exceptions for "XC16SyncGroups" folder in "XC16SyncGroupsTests" target */ = {
+ FB5D38CE2D2E61BA00005FF8 /* PBXFileSystemSynchronizedBuildFileExceptionSet */ = {
isa = PBXFileSystemSynchronizedBuildFileExceptionSet;
membershipExceptions = (
Foo.swift,
@@ -42,8 +42,8 @@
FB5D38AD2D2E618600005FF8 /* XC16SyncGroups */ = {
isa = PBXFileSystemSynchronizedRootGroup;
exceptions = (
- FB5D38CD2D2E61BA00005FF8 /* Exceptions for "XC16SyncGroups" folder in "XC16SyncGroups" target */,
- FB5D38CE2D2E61BA00005FF8 /* Exceptions for "XC16SyncGroups" folder in "XC16SyncGroupsTests" target */,
+ FB5D38CD2D2E61BA00005FF8 /* PBXFileSystemSynchronizedBuildFileExceptionSet */,
+ FB5D38CE2D2E61BA00005FF8 /* PBXFileSystemSynchronizedBuildFileExceptionSet */,
);
path = XC16SyncGroups;
sourceTree = "<group>";
…SynchronizedGroupBuildPhaseMembershipExceptionSet
I'm looking into this one. |
Thanks, I couldn't find the time to bring it over the finish line. |
…rshipExceptionSet
PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet
PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet
Sources/XcodeProj/Objects/Files/PBXFileSystemSynchronizedRootGroup.swift
Show resolved
Hide resolved
Sources/XcodeProj/Objects/Files/PBXFileSystemSynchronizedRootGroup.swift
Show resolved
Hide resolved
…haseMembershipExceptionSet
…se to PBXObjectDictionaryEntry
Resolves #838
Short description 📝
This PR is an update to the original one #874 I simply resolved conflicts since the original author is not responding.
NOTE: Please find all the reasoning in original pull request description.