Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XCSharedData Writable conformance to include WorkspaceSettings #743

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

dayton-bobbitt
Copy link
Contributor

Resolves #738

Short description 📝

Update XCSharedData Writable conformance so that WorkspaceSettings are wrriten.

Solution 📦

There was already a pattern defined for writing XCSharedData properties (schemes and breakpoints), and so I followed the same pattern to write the workspaceSettings property.

Implementation 👩‍💻👨‍💻

Detail in a checklist the steps that you took to implement the PR.

  • Write a test case in XcodeProjTests that fails if XcodeProj.write doesn’t write all expected files
  • Run the test and see that it fails
  • Update XCSharedData Writable conformance to write WorkspaceSettings
  • Run XcodeProjTests again and see that it passes

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dayton-bobbitt
Copy link
Contributor Author

Thanks @kwridan! Is there anyone else in particular we need to review this change before it can be merged?

@kwridan
Copy link
Collaborator

kwridan commented Mar 6, 2023

Thanks @brentleyjones for the quick review!

@kwridan kwridan merged commit 1c8daed into tuist:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XcodeProj Writable conformance does not include WorkspaceSettings
3 participants