Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AEXML v4.6.1 #632

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Update AEXML v4.6.1 #632

merged 2 commits into from
Sep 13, 2021

Conversation

nnsnodnb
Copy link
Contributor

@nnsnodnb nnsnodnb commented Aug 26, 2021

Resolves https://github.com/tuist/xcodeproj/issues/YYY

Short description πŸ“

Update AEXML version to v4.6.1

Solution πŸ“¦

I fixed XML's newline escaping.
tadija/AEXML#177

Implementation πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

  • Step 1 Fork -> Clone
  • Step 2 Executed open Package.swift
  • Step 3 Updated AEXML version in xcodeproj.podspec , Cartfile , Carffile.resolved & Package.swift

@nnsnodnb
Copy link
Contributor Author

Hi.
Is it possible to remove .swift-version from this repository?
Then, I was able to resolve dependencies in my environment.

@pepicrft
Copy link
Contributor

@all-contributors add @nnsnodnb for code

@allcontributors
Copy link
Contributor

@pepibumur

I've put up a pull request to add @nnsnodnb! πŸŽ‰

@pepicrft
Copy link
Contributor

Thanks a lot for helping with this @nnsnodnb. If CI is green I'll merge the PR.

@pepicrft pepicrft merged commit 73828de into tuist:main Sep 13, 2021
@fortmarek
Copy link
Member

This seems like it has broken the checks, it's probably worth some investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants