Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new product types. #618

Merged
merged 4 commits into from
Jun 17, 2021
Merged

Conversation

vgorloff
Copy link
Contributor

@vgorloff vgorloff commented Jun 15, 2021

Resolves #617

Short description 📝

Added definitions for com.apple.product-type.driver-extension and com.apple.product-type.system-extension

Here is how pbxproj file looks like:

80FE40502679519400D7853F /* MyDriver */ = {
	isa = PBXNativeTarget;
	buildConfigurationList = 80FE405D2679519400D7853F /* Build configuration list for PBXNativeTarget "MyDriver" */;
	buildPhases = (
		80FE404C2679519400D7853F /* Headers */,
		80FE404D2679519400D7853F /* Sources */,
		80FE404E2679519400D7853F /* Frameworks */,
		80FE404F2679519400D7853F /* Resources */,
	);
	buildRules = (
	);
	dependencies = (
	);
	name = MyDriver;
	productName = MyDriver;
	productReference = 80FE40512679519400D7853F /* abc.xyz.any.MyDriver.dext */;
	productType = "com.apple.product-type.driver-extension";
};
80FE40632679523400D7853F /* MySysExtension */ = {
	isa = PBXNativeTarget;
	buildConfigurationList = 80FE406E2679523400D7853F /* Build configuration list for PBXNativeTarget "MySysExtension" */;
	buildPhases = (
		80FE40602679523400D7853F /* Sources */,
		80FE40612679523400D7853F /* Frameworks */,
		80FE40622679523400D7853F /* Resources */,
	);
	buildRules = (
	);
	dependencies = (
	);
	name = MySysExtension;
	productName = MySysExtension;
	productReference = 80FE40642679523400D7853F /* abc.xyz.any.xxx.MySysExtension.systemextension */;
	productType = "com.apple.product-type.system-extension";
};

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @vgorloff

Mind updating the change log to raise visibility of those changes in the next release?

@vgorloff vgorloff requested a review from kwridan June 16, 2021 19:00
Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #618 (98e37f5) into main (6910a7f) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
- Coverage   84.17%   84.16%   -0.01%     
==========================================
  Files         154      154              
  Lines        8718     8726       +8     
==========================================
+ Hits         7338     7344       +6     
- Misses       1380     1382       +2     
Impacted Files Coverage Δ
...ces/XcodeProj/Objects/Targets/PBXProductType.swift 55.88% <50.00%> (-0.79%) ⬇️
...rojTests/Objects/Targets/PBXProductTypeTests.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6910a7f...98e37f5. Read the comment docs.

@vgorloff vgorloff requested a review from kwridan June 16, 2021 22:36
@kwridan kwridan requested review from fortmarek and pepicrft June 17, 2021 05:56
@kwridan kwridan removed request for pepicrft and fortmarek June 17, 2021 05:59
@vgorloff vgorloff requested a review from kwridan June 17, 2021 07:46
@kwridan kwridan requested review from fortmarek and pepicrft June 17, 2021 07:54
@pepicrft pepicrft merged commit 1e3cfc3 into tuist:main Jun 17, 2021
@vgorloff vgorloff deleted the feature/vg-new-product-types branch June 17, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product types system-extension and driver-extension are missing.
4 participants