Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add group to have correct parent set #614

Merged

Conversation

avdyushin
Copy link
Contributor

Resolves #613

Short description πŸ“

Fixed addGroup method and added unit test for this case

Solution πŸ“¦

Typo?

Implementation πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

newGroup.parent = group instead of self

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2021

Codecov Report

Merging #614 (cccf94f) into main (45e349e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   84.14%   84.17%   +0.02%     
==========================================
  Files         154      154              
  Lines        8706     8718      +12     
==========================================
+ Hits         7326     7338      +12     
  Misses       1380     1380              
Impacted Files Coverage Ξ”
Sources/XcodeProj/Objects/Files/PBXGroup.swift 78.84% <100.00%> (ΓΈ)
...s/XcodeProjTests/Objects/Files/PBXGroupTests.swift 93.75% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 45e349e...cccf94f. Read the comment docs.

@avdyushin
Copy link
Contributor Author

How it's possible to trigger CI build for this PR again?

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @avdyushin.

Mind rebasing on latest main where some fixes for linux have already landed, this may help resolve the CI issue you saw?

lastly, please update CHANGELOG.md to help raise awareness of this fix in the next release.

@kwridan kwridan requested a review from fortmarek June 1, 2021 09:30
@fortmarek
Copy link
Member

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding group set incorrect parent in case of complex path
4 participants