Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER #608

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Conversation

fortmarek
Copy link
Member

Short description 📝

As mentioned here, CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER is a recommended setting turned on by default, so we should do the same.

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #608 (41883df) into main (0c88990) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
- Coverage   84.28%   84.27%   -0.01%     
==========================================
  Files         154      154              
  Lines        8688     8689       +1     
==========================================
  Hits         7323     7323              
- Misses       1365     1366       +1     
Impacted Files Coverage Δ
...ources/XcodeProj/Utils/BuildSettingsProvider.swift 54.15% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c88990...41883df. Read the comment docs.

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fortmarek

@fortmarek fortmarek merged commit 5860027 into main Apr 27, 2021
@fortmarek fortmarek deleted the quoted_header branch April 27, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants