-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows passing BuildableIdentifier
String to BuildableReference
initializer
#605
Allows passing BuildableIdentifier
String to BuildableReference
initializer
#605
Conversation
Codecov Report
@@ Coverage Diff @@
## main #605 +/- ##
==========================================
- Coverage 84.24% 84.18% -0.06%
==========================================
Files 154 154
Lines 8682 8688 +6
==========================================
Hits 7314 7314
- Misses 1368 1374 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change makes sense 👍
Can other also review it? 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @freddi-kit
Looking at the code, it seemed .string()
references were exclusives used when deserialising the scheme and making a new one relied on PBXObject
s hence why it wasn't exposed - thanks for the additional context pointing out the use-case where Swift Package integrations work differently requiring manually setting the string directly.
Can someone help to merge it? |
Sorry for the hassle @freddi-kit - mind rebasing on latest main + updating the change log? |
f793723
to
32774ad
Compare
Codecov Report
@@ Coverage Diff @@
## main #605 +/- ##
==========================================
- Coverage 84.20% 84.14% -0.06%
==========================================
Files 154 154
Lines 8700 8706 +6
==========================================
Hits 7326 7326
- Misses 1374 1380 +6
Continue to review full report at Codecov.
|
I changed CHANGELOG and rebased main, Thank you! |
Short description 📝
At
BuildableReference
, it would be better to passbuildableIdentifier
String by the user on some caseFor example, when Xcode adding testing for Local Swift Package in scheme like below image,
(
MyLibrary
is a local swift package)The (AppName).xcscheme will be like the below code.
FYI: `MyLibrary`'s Package.swift
As you can see, the application test's
BlueprintIdentifier
is for reference of xctest. ButMyLibrary
'sBlueprintIdentifier
is not the same format with main app one(96072DB32624C6A200AB94A5
). It is the name of test target ofMyLibrary
.Currently,
BlueprintIdentifier
's initalizer only setBlueprintIdentifier
via receivedPBXObject
likeHowever, it is hard to pass the actual
PBXObject
's reference when addingBuildableReference
for testing Local Swift Package.Solution 📦
So I added an initializer that receives
BlueprintIdentifier
as a string to make it easy to set as expected.Implementation 👩💻👨💻
BuildableReference
which receivesBuildableIdentifier
string