[Fix] JSON decoder not properly decoding defaultConfigurationIsVisible
in some projects
#593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #592
Short description 📝
This PR should fix decoding
defaultConfigurationIsVisible
(and other booleans) of multiple types of encoding (ie. plist encoded which encodes to a proper boolean or a normal pbxproj which encodes into a string).Solution 📦
Try decoding it as a string like before, then an int, then a boolean and finally return nil if it cannot. Notice each try is marked with
try?
so it doesn't actually throw in case there is a type mismatch.Implementation 👩💻👨💻