Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for enabling test code coverage #166

Merged
merged 1 commit into from
Nov 23, 2017
Merged

Add support for enabling test code coverage #166

merged 1 commit into from
Nov 23, 2017

Conversation

kastiglione
Copy link

Short description 📝

This change allows generation of schemes where TestAction has codeCoverageEnabled enabled.

Solution 📦

Update the TestAction class to optionally be constructed with a codeCoverageEnabled value, and updated the generated XML to include the codeCoverageEnabled value.

Implementation 👩‍💻👨‍💻

  • Added property to codeCoverageEnabled to TestAction
  • Updated TestAction's init functions and also xmlElement
  • Added new assert in XCSchemeSpec

@welcome
Copy link

welcome bot commented Nov 22, 2017

Thanks for opening this pull request! Please check out our contributing guidelines.

Add support for enabling test code coverage
379baed 
This change allows generation of schemes where `TestAction` has
`codeCoverageEnabled` enabled.
alexruperez
alexruperez approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor

@alexruperez alexruperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much needed! 👍

@alexruperez alexruperez mentioned this pull request Nov 23, 2017
Closed
@pepicrft pepicrft added this to the 1.5.0 milestone Nov 23, 2017
@pepicrft
Copy link
Contributor

Great improvement and first contribution @kastiglione 😛

@pepicrft pepicrft merged commit feaa00e into tuist:master Nov 23, 2017
@welcome
Copy link

welcome bot commented Nov 23, 2017

Congrats on merging your first pull request! We here at xcode.swift are proud of you! Join our slack channel to talk to other contributors.

@kastiglione
Copy link
Author

thanks @alexruperez and @pepibumur

@kastiglione kastiglione deleted the test-codecov branch November 23, 2017 18:17
@kastiglione kastiglione mentioned this pull request Nov 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexruperez alexruperez alexruperez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kastiglione @pepicrft @alexruperez