Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lint): update lint rules #114

Merged
merged 12 commits into from
Jan 25, 2025
Merged

refactor(lint): update lint rules #114

merged 12 commits into from
Jan 25, 2025

Conversation

tsutsu3
Copy link
Owner

@tsutsu3 tsutsu3 commented Jan 25, 2025

No description provided.

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 48.68421% with 234 lines in your changes missing coverage. Please review.

Project coverage is 56.43%. Comparing base (9f89a90) to head (5f90a97).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ings/advanced_settings/app_unlock_setup_modal.dart 0.00% 39 Missing ⚠️
lib/screens/servers/servers_tile_item.dart 0.00% 22 Missing ⚠️
lib/main.dart 0.00% 19 Missing ⚠️
...ens/statistics/statistics_queries_servers_tab.dart 67.34% 16 Missing ⚠️
...gs/app_settings/advanced_settings/reset_modal.dart 53.12% 15 Missing ⚠️
lib/screens/servers/servers.dart 0.00% 13 Missing ⚠️
lib/screens/statistics/statistics_list.dart 71.42% 8 Missing ⚠️
lib/functions/status_updater.dart 0.00% 7 Missing ⚠️
.../screens/home/widgets/clients_last_hours_line.dart 50.00% 6 Missing ⚠️
lib/screens/unlock.dart 57.14% 6 Missing ⚠️
... and 34 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   56.32%   56.43%   +0.10%     
==========================================
  Files         134      134              
  Lines        8312     8305       -7     
==========================================
+ Hits         4682     4687       +5     
+ Misses       3630     3618      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
52.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@tsutsu3 tsutsu3 merged commit daaae1e into main Jan 25, 2025
9 of 12 checks passed
@tsutsu3 tsutsu3 deleted the change-linter branch January 25, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant